OSDN Git Service

drm/nouveau/sched: Don't pass user flags to drm_syncobj_find_fence()
authorFaith Ekstrand <faith@gfxstrand.net>
Mon, 7 Aug 2023 23:41:44 +0000 (18:41 -0500)
committerDanilo Krummrich <dakr@redhat.com>
Tue, 8 Aug 2023 02:53:49 +0000 (04:53 +0200)
The flags field in drm_syncobj_find_fence() takes SYNCOBJ_WAIT flags
from the syncobj UAPI whereas sync->flags is from the nouveau UAPI. What
we actually want is 0 flags which tells it to just try to find the
fence and then return without waiting.

Fixes: b88baab82871 ("drm/nouveau: implement new VM_BIND uAPI")
Cc: Danilo Krummrich <dakr@redhat.com>
Cc: Dave Airlie <airlied@redhat.com>
Reviewed-by: Danilo Krummrich <dakr@redhat.com>
Signed-off-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Signed-off-by: Danilo Krummrich <dakr@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230807234210.175968-1-faith.ekstrand@collabora.com
drivers/gpu/drm/nouveau/nouveau_sched.c

index b3b59fb..3424a1b 100644 (file)
@@ -142,7 +142,7 @@ sync_find_fence(struct nouveau_job *job,
 
        ret = drm_syncobj_find_fence(job->file_priv,
                                     sync->handle, point,
-                                    sync->flags, fence);
+                                    0 /* flags */, fence);
        if (ret)
                return ret;