These TODOs aren't in scope for the wrapper libraries.
Leave the few TODOs that have bugs tracking them, and the ones that
are from autogenerated metadata.
Test: Builds
Bug:
34108979
Change-Id: Ib28467a4fbcfaab4a0809334bc62eabb9290797a
}
}
- // TODO: Make above get_camera_metadata_section_from_name ?
-
if (section == NULL) {
return NAME_NOT_FOUND;
} else {
}
int CameraDevice::sLockBuffer(struct preview_stream_ops*, buffer_handle_t*) {
- // TODO: make sure lock_buffer is indeed a no-op (and will always be)
return 0;
}
cameraInfo.facing = (CameraFacing) info.facing;
// Device 1.0 does not support external camera facing.
// The closest approximation would be front camera.
- // TODO: figure out should we override here or let
- // camera service handle it.
if (cameraInfo.facing == CameraFacing::EXTERNAL) {
cameraInfo.facing = CameraFacing::FRONT;
}
return Void();
}
- // TODO: we also need to keep a wp list of all generated devices to notify
- // devices of device present status change, but then each device might
- // need a sp<provider> to keep provider alive until all device closed?
- // Problem: do we have external camera products to test this?
sp<android::hardware::camera::device::V3_2::implementation::CameraDevice> device =
new android::hardware::camera::device::V3_2::implementation::CameraDevice(
mModule, cameraId, mCameraDeviceNames);