OSDN Git Service

net: mvpp2: debugfs: fix incorrect bitwise operator
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Wed, 18 Jul 2018 13:08:46 +0000 (08:08 -0500)
committerDavid S. Miller <davem@davemloft.net>
Wed, 18 Jul 2018 17:55:42 +0000 (10:55 -0700)
The use of the | operator always leads to true, which looks rather
suspect in this case.

Fix this by using & instead.

Addresses-Coverity-ID: 1471903 ("Wrong operator used")
Fixes: dba1d918da02 ("net: mvpp2: debugfs: add entries for classifier flows")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c

index 02dfef1..f9744a6 100644 (file)
@@ -245,7 +245,7 @@ static int mvpp2_dbgfs_flow_c2_enable_show(struct seq_file *s, void *unused)
 
        mvpp2_cls_c2_read(port->priv, MVPP22_CLS_C2_RSS_ENTRY(port->id), &c2);
 
-       enabled = !!(c2.attr[2] | MVPP22_CLS_C2_ATTR2_RSS_EN);
+       enabled = !!(c2.attr[2] & MVPP22_CLS_C2_ATTR2_RSS_EN);
 
        seq_printf(s, "%d\n", enabled);