OSDN Git Service

staging: rtl8723bs: place constant on the right side of the test
authorFabio Aiuto <fabioaiuto83@gmail.com>
Mon, 5 Apr 2021 16:49:54 +0000 (18:49 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 6 Apr 2021 10:54:01 +0000 (12:54 +0200)
fix following post-hook checkpatch issue:

WARNING: Comparisons should place the constant on the right side of the test
85: FILE: drivers/staging/rtl8723bs/hal/sdio_halinit.c:676:
+ if (_FAIL == ret)

Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/8a6967abaef8b2edad6dc829dd232a7f048899d2.1617640221.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/hal/sdio_halinit.c

index cec72ab..5553246 100644 (file)
@@ -673,7 +673,7 @@ static u32 rtl8723bs_hal_init(struct adapter *padapter)
 /*     rtw_hal_disable_interrupt(padapter); */
 
        ret = _InitPowerOn_8723BS(padapter);
-       if (_FAIL == ret)
+       if (ret == _FAIL)
                return _FAIL;
 
        rtw_write8(padapter, REG_EARLY_MODE_CONTROL, 0);