OSDN Git Service

rtc: max8997: Fix the returned value in case of error in 'max8997_rtc_read_alarm()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Wed, 14 Nov 2018 17:19:51 +0000 (18:19 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 13 Dec 2019 07:51:35 +0000 (08:51 +0100)
[ Upstream commit 41ef3878203cd9218d92eaa07df4b85a2cb128fb ]

In case of error, we return 0.
This is spurious and not consistent with the other functions of the driver.
Propagate the error code instead.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/rtc/rtc-max8997.c

index 08c661a..20e50d9 100644 (file)
@@ -215,7 +215,7 @@ static int max8997_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm)
 
 out:
        mutex_unlock(&info->lock);
-       return 0;
+       return ret;
 }
 
 static int max8997_rtc_stop_alarm(struct max8997_rtc_info *info)