OSDN Git Service

drm/amd/powerplay: delete flag PP_VALID
authorRex Zhu <Rex.Zhu@amd.com>
Thu, 28 Sep 2017 08:12:51 +0000 (16:12 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 6 Oct 2017 20:47:49 +0000 (16:47 -0400)
don't need to check pp_valid, all pp
export functions are moved to ip_funcs
and pp_funcs. so just need to check the
function point.

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/powerplay/amd_powerplay.c
drivers/gpu/drm/amd/powerplay/inc/pp_instance.h

index 71bb7d9..3c8ef4b 100644 (file)
@@ -37,7 +37,7 @@ static int pp_dpm_dispatch_tasks(void *handle, enum amd_pp_task task_id,
 
 static inline int pp_check(struct pp_instance *handle)
 {
-       if (handle == NULL || handle->pp_valid != PP_VALID)
+       if (handle == NULL)
                return -EINVAL;
 
        if (handle->hwmgr == NULL || handle->hwmgr->smumgr_funcs == NULL)
@@ -64,7 +64,6 @@ static int amd_powerplay_create(struct amd_pp_init *pp_init,
        if (instance == NULL)
                return -ENOMEM;
 
-       instance->pp_valid = PP_VALID;
        instance->chip_family = pp_init->chip_family;
        instance->chip_id = pp_init->chip_id;
        instance->pm_en = pp_init->pm_en;
index 25fb146..7d1eec5 100644 (file)
 
 #include "hwmgr.h"
 
-#define PP_VALID  0x1F1F1F1F
-
 struct pp_instance {
-       uint32_t pp_valid;
        uint32_t chip_family;
        uint32_t chip_id;
        bool pm_en;