OSDN Git Service

media: atomisp: fix inverted logic in buffers_needed()
authorTsuchiya Yuto <kitakar@gmail.com>
Sun, 17 Oct 2021 16:19:43 +0000 (01:19 +0900)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 15 Nov 2021 08:11:35 +0000 (08:11 +0000)
When config.mode is IA_CSS_INPUT_MODE_BUFFERED_SENSOR, it rather needs
buffers. Fix it by inverting the return value.

Fixes: 3c0538fbad9f ("media: atomisp: get rid of most checks for ISP2401 version")
Signed-off-by: Tsuchiya Yuto <kitakar@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/pci/sh_css_mipi.c

index 75489f7..483d40a 100644 (file)
@@ -374,17 +374,17 @@ static bool buffers_needed(struct ia_css_pipe *pipe)
 {
        if (!IS_ISP2401) {
                if (pipe->stream->config.mode == IA_CSS_INPUT_MODE_BUFFERED_SENSOR)
-                       return false;
-               else
                        return true;
+               else
+                       return false;
        }
 
        if (pipe->stream->config.mode == IA_CSS_INPUT_MODE_BUFFERED_SENSOR ||
            pipe->stream->config.mode == IA_CSS_INPUT_MODE_TPG ||
            pipe->stream->config.mode == IA_CSS_INPUT_MODE_PRBS)
-               return false;
+               return true;
 
-       return true;
+       return false;
 }
 
 int