OSDN Git Service

drm: make various debugfs_init() functions return 0
authorWambui Karuga <wambui.karugax@gmail.com>
Tue, 10 Mar 2020 13:31:19 +0000 (16:31 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 18 Mar 2020 15:45:22 +0000 (16:45 +0100)
Since commit 987d65d01356 (drm: debugfs: make
drm_debugfs_create_files() never fail), drm_debugfs_create_files() never
fails and should return void. Therefore, remove its use as the
return value of various debugfs_init() functions in drm, and have these
functions return 0 directly.

v2: convert debugfs_init() functions to return 0 instead of void to
avoid build breakage.

References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html
Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20200310133121.27913-16-wambui.karugax@gmail.com
drivers/gpu/drm/drm_atomic.c
drivers/gpu/drm/drm_client.c
drivers/gpu/drm/drm_framebuffer.c

index 9ccfbf2..c0056d9 100644 (file)
@@ -1643,8 +1643,9 @@ static const struct drm_info_list drm_atomic_debugfs_list[] = {
 
 int drm_atomic_debugfs_init(struct drm_minor *minor)
 {
-       return drm_debugfs_create_files(drm_atomic_debugfs_list,
-                       ARRAY_SIZE(drm_atomic_debugfs_list),
-                       minor->debugfs_root, minor);
+       drm_debugfs_create_files(drm_atomic_debugfs_list,
+                                ARRAY_SIZE(drm_atomic_debugfs_list),
+                                minor->debugfs_root, minor);
+       return 0;
 }
 #endif
index 6b0c6ef..82fbdee 100644 (file)
@@ -459,8 +459,10 @@ static const struct drm_info_list drm_client_debugfs_list[] = {
 
 int drm_client_debugfs_init(struct drm_minor *minor)
 {
-       return drm_debugfs_create_files(drm_client_debugfs_list,
-                                       ARRAY_SIZE(drm_client_debugfs_list),
-                                       minor->debugfs_root, minor);
+       drm_debugfs_create_files(drm_client_debugfs_list,
+                                ARRAY_SIZE(drm_client_debugfs_list),
+                                minor->debugfs_root, minor);
+
+       return 0;
 }
 #endif
index 57ac94c..46be882 100644 (file)
@@ -1209,8 +1209,10 @@ static const struct drm_info_list drm_framebuffer_debugfs_list[] = {
 
 int drm_framebuffer_debugfs_init(struct drm_minor *minor)
 {
-       return drm_debugfs_create_files(drm_framebuffer_debugfs_list,
-                               ARRAY_SIZE(drm_framebuffer_debugfs_list),
-                               minor->debugfs_root, minor);
+       drm_debugfs_create_files(drm_framebuffer_debugfs_list,
+                                ARRAY_SIZE(drm_framebuffer_debugfs_list),
+                                minor->debugfs_root, minor);
+
+       return 0;
 }
 #endif