OSDN Git Service

net: ethernet: ti: am65-cpts: Switch to use dev_err_probe() helper
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 15 Sep 2022 11:42:08 +0000 (19:42 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 21 Sep 2022 12:50:03 +0000 (13:50 +0100)
dev_err() can be replace with dev_err_probe() which will check if error
code is -EPROBE_DEFER.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/am65-cpts.c

index c30a6e5..e2f0fb2 100644 (file)
@@ -943,9 +943,7 @@ struct am65_cpts *am65_cpts_create(struct device *dev, void __iomem *regs,
        cpts->irq = of_irq_get_byname(node, "cpts");
        if (cpts->irq <= 0) {
                ret = cpts->irq ?: -ENXIO;
-               if (ret != -EPROBE_DEFER)
-                       dev_err(dev, "Failed to get IRQ number (err = %d)\n",
-                               ret);
+               dev_err_probe(dev, ret, "Failed to get IRQ number\n");
                return ERR_PTR(ret);
        }
 
@@ -965,8 +963,7 @@ struct am65_cpts *am65_cpts_create(struct device *dev, void __iomem *regs,
        cpts->refclk = devm_get_clk_from_child(dev, node, "cpts");
        if (IS_ERR(cpts->refclk)) {
                ret = PTR_ERR(cpts->refclk);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(dev, "Failed to get refclk %d\n", ret);
+               dev_err_probe(dev, ret, "Failed to get refclk\n");
                return ERR_PTR(ret);
        }