OSDN Git Service

video: fbdev: pxa3xx-gcu: Remove unnecessary print function dev_err()
authorYang Li <yang.lee@linux.alibaba.com>
Tue, 1 Feb 2022 12:32:02 +0000 (20:32 +0800)
committerHelge Deller <deller@gmx.de>
Tue, 1 Feb 2022 19:45:52 +0000 (20:45 +0100)
The print function dev_err() is redundant because platform_get_irq()
already prints an error.

Eliminate the follow coccicheck warning:
./drivers/video/fbdev/pxa3xx-gcu.c:615:2-9: line 615 is redundant
because platform_get_irq() already prints an error

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/pxa3xx-gcu.c

index 9239ecd..350b313 100644 (file)
@@ -611,10 +611,8 @@ static int pxa3xx_gcu_probe(struct platform_device *pdev)
 
        /* request the IRQ */
        irq = platform_get_irq(pdev, 0);
-       if (irq < 0) {
-               dev_err(dev, "no IRQ defined: %d\n", irq);
+       if (irq < 0)
                return irq;
-       }
 
        ret = devm_request_irq(dev, irq, pxa3xx_gcu_handle_irq,
                               0, DRV_NAME, priv);