OSDN Git Service

PCI: controller: Convert to devm_platform_ioremap_resource_byname()
authorDejin Zheng <zhengdejin5@gmail.com>
Tue, 2 Jun 2020 17:16:01 +0000 (01:16 +0800)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Fri, 10 Jul 2020 10:50:23 +0000 (11:50 +0100)
Use devm_platform_ioremap_resource_byname() to simplify the code,
since it calls respectively platform_get_resource_byname() and
devm_ioremap_resource().

Link: https://lore.kernel.org/r/20200602171601.17630-1-zhengdejin5@gmail.com
Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
drivers/pci/controller/cadence/pcie-cadence-ep.c
drivers/pci/controller/cadence/pcie-cadence-host.c
drivers/pci/controller/pci-tegra.c
drivers/pci/controller/pci-xgene.c
drivers/pci/controller/pcie-altera-msi.c
drivers/pci/controller/pcie-altera.c
drivers/pci/controller/pcie-mediatek.c
drivers/pci/controller/pcie-rockchip.c

index 1c15c83..74ffa03 100644 (file)
@@ -408,8 +408,7 @@ int cdns_pcie_ep_setup(struct cdns_pcie_ep *ep)
 
        pcie->is_rc = false;
 
-       res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "reg");
-       pcie->reg_base = devm_ioremap_resource(dev, res);
+       pcie->reg_base = devm_platform_ioremap_resource_byname(pdev, "reg");
        if (IS_ERR(pcie->reg_base)) {
                dev_err(dev, "missing \"reg\"\n");
                return PTR_ERR(pcie->reg_base);
index 9f77e47..59b9b3d 100644 (file)
@@ -217,8 +217,7 @@ int cdns_pcie_host_setup(struct cdns_pcie_rc *rc)
        rc->device_id = 0xffff;
        of_property_read_u32(np, "device-id", &rc->device_id);
 
-       res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "reg");
-       pcie->reg_base = devm_ioremap_resource(dev, res);
+       pcie->reg_base = devm_platform_ioremap_resource_byname(pdev, "reg");
        if (IS_ERR(pcie->reg_base)) {
                dev_err(dev, "missing \"reg\"\n");
                return PTR_ERR(pcie->reg_base);
index 82fb36e..71bf4b2 100644 (file)
@@ -1462,7 +1462,7 @@ static int tegra_pcie_get_resources(struct tegra_pcie *pcie)
 {
        struct device *dev = pcie->dev;
        struct platform_device *pdev = to_platform_device(dev);
-       struct resource *pads, *afi, *res;
+       struct resource *res;
        const struct tegra_pcie_soc *soc = pcie->soc;
        int err;
 
@@ -1486,15 +1486,13 @@ static int tegra_pcie_get_resources(struct tegra_pcie *pcie)
                }
        }
 
-       pads = platform_get_resource_byname(pdev, IORESOURCE_MEM, "pads");
-       pcie->pads = devm_ioremap_resource(dev, pads);
+       pcie->pads = devm_platform_ioremap_resource_byname(pdev, "pads");
        if (IS_ERR(pcie->pads)) {
                err = PTR_ERR(pcie->pads);
                goto phys_put;
        }
 
-       afi = platform_get_resource_byname(pdev, IORESOURCE_MEM, "afi");
-       pcie->afi = devm_ioremap_resource(dev, afi);
+       pcie->afi = devm_platform_ioremap_resource_byname(pdev, "afi");
        if (IS_ERR(pcie->afi)) {
                err = PTR_ERR(pcie->afi);
                goto phys_put;
index 5aee802..4c783cf 100644 (file)
@@ -355,8 +355,7 @@ static int xgene_pcie_map_reg(struct xgene_pcie_port *port,
        if (IS_ERR(port->csr_base))
                return PTR_ERR(port->csr_base);
 
-       res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "cfg");
-       port->cfg_base = devm_ioremap_resource(dev, res);
+       port->cfg_base = devm_platform_ioremap_resource_byname(pdev, "cfg");
        if (IS_ERR(port->cfg_base))
                return PTR_ERR(port->cfg_base);
        port->cfg_addr = res->start;
index 16d9389..613e19a 100644 (file)
@@ -228,8 +228,7 @@ static int altera_msi_probe(struct platform_device *pdev)
        mutex_init(&msi->lock);
        msi->pdev = pdev;
 
-       res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "csr");
-       msi->csr_base = devm_ioremap_resource(&pdev->dev, res);
+       msi->csr_base = devm_platform_ioremap_resource_byname(pdev, "csr");
        if (IS_ERR(msi->csr_base)) {
                dev_err(&pdev->dev, "failed to map csr memory\n");
                return PTR_ERR(msi->csr_base);
index 26ac3ad..4ffe382 100644 (file)
@@ -696,17 +696,14 @@ static int altera_pcie_parse_dt(struct altera_pcie *pcie)
 {
        struct device *dev = &pcie->pdev->dev;
        struct platform_device *pdev = pcie->pdev;
-       struct resource *cra;
-       struct resource *hip;
 
-       cra = platform_get_resource_byname(pdev, IORESOURCE_MEM, "Cra");
-       pcie->cra_base = devm_ioremap_resource(dev, cra);
+       pcie->cra_base = devm_platform_ioremap_resource_byname(pdev, "Cra");
        if (IS_ERR(pcie->cra_base))
                return PTR_ERR(pcie->cra_base);
 
        if (pcie->pcie_data->version == ALTERA_PCIE_V2) {
-               hip = platform_get_resource_byname(pdev, IORESOURCE_MEM, "Hip");
-               pcie->hip_base = devm_ioremap_resource(&pdev->dev, hip);
+               pcie->hip_base =
+                       devm_platform_ioremap_resource_byname(pdev, "Hip");
                if (IS_ERR(pcie->hip_base))
                        return PTR_ERR(pcie->hip_base);
        }
index ebfa7d5..d8e3827 100644 (file)
@@ -905,7 +905,6 @@ static int mtk_pcie_parse_port(struct mtk_pcie *pcie,
                               int slot)
 {
        struct mtk_pcie_port *port;
-       struct resource *regs;
        struct device *dev = pcie->dev;
        struct platform_device *pdev = to_platform_device(dev);
        char name[10];
@@ -916,8 +915,7 @@ static int mtk_pcie_parse_port(struct mtk_pcie *pcie,
                return -ENOMEM;
 
        snprintf(name, sizeof(name), "port%d", slot);
-       regs = platform_get_resource_byname(pdev, IORESOURCE_MEM, name);
-       port->base = devm_ioremap_resource(dev, regs);
+       port->base = devm_platform_ioremap_resource_byname(pdev, name);
        if (IS_ERR(port->base)) {
                dev_err(dev, "failed to map port%d base\n", slot);
                return PTR_ERR(port->base);
index c53d132..904dec0 100644 (file)
@@ -45,9 +45,8 @@ int rockchip_pcie_parse_dt(struct rockchip_pcie *rockchip)
                        return -EINVAL;
        }
 
-       regs = platform_get_resource_byname(pdev, IORESOURCE_MEM,
-                                           "apb-base");
-       rockchip->apb_base = devm_ioremap_resource(dev, regs);
+       rockchip->apb_base =
+               devm_platform_ioremap_resource_byname(pdev, "apb-base");
        if (IS_ERR(rockchip->apb_base))
                return PTR_ERR(rockchip->apb_base);