OSDN Git Service

staging: gasket: gasket_get_device drop check for NULL pci_dev
authorTodd Poynor <toddpoynor@google.com>
Sat, 21 Jul 2018 13:35:00 +0000 (06:35 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Jul 2018 11:56:46 +0000 (13:56 +0200)
The pci_dev field of a struct gasket_dev can never be NULL, there's no
need to check for this in gasket_get_device().

Reported-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gasket/gasket_core.c

index e82f8ce..8265d54 100644 (file)
@@ -2026,9 +2026,7 @@ const struct gasket_driver_desc *gasket_get_driver_desc(struct gasket_dev *dev)
  */
 struct device *gasket_get_device(struct gasket_dev *dev)
 {
-       if (dev->pci_dev)
-               return &dev->pci_dev->dev;
-       return NULL;
+       return &dev->pci_dev->dev;
 }
 
 /**