OSDN Git Service

drm/doc: add WARNING for drm_device::struct_mutex
authorEmil Velikov <emil.velikov@collabora.com>
Fri, 15 May 2020 09:50:45 +0000 (10:50 +0100)
committerEmil Velikov <emil.l.velikov@gmail.com>
Tue, 19 May 2020 20:52:25 +0000 (21:52 +0100)
The mutex should be used, only by legacy drivers. Add a big warning to
deter people from using it.

Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20200515095118.2743122-6-emil.l.velikov@gmail.com
include/drm/drm_device.h

index a55874d..0988351 100644 (file)
@@ -146,6 +146,9 @@ struct drm_device {
         * @struct_mutex:
         *
         * Lock for others (not &drm_minor.master and &drm_file.is_master)
+        *
+        * WARNING:
+        * Only drivers annotated with DRIVER_LEGACY should be using this.
         */
        struct mutex struct_mutex;