OSDN Git Service

p54: Use skb_peek_tail() instead of direct head pointer accesses.
authorDavid S. Miller <davem@davemloft.net>
Wed, 8 Aug 2018 06:42:03 +0000 (23:42 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 10 Sep 2018 17:06:53 +0000 (10:06 -0700)
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wireless/intersil/p54/txrx.c

index 3a4214d..7907845 100644 (file)
@@ -121,8 +121,8 @@ static int p54_assign_address(struct p54_common *priv, struct sk_buff *skb)
        }
        if (unlikely(!target_skb)) {
                if (priv->rx_end - last_addr >= len) {
-                       target_skb = priv->tx_queue.prev;
-                       if (!skb_queue_empty(&priv->tx_queue)) {
+                       target_skb = skb_peek_tail(&priv->tx_queue);
+                       if (target_skb) {
                                info = IEEE80211_SKB_CB(target_skb);
                                range = (void *)info->rate_driver_data;
                                target_addr = range->end_addr;