OSDN Git Service

HID: mcp2221: fix report layout for gpio get
authorLouis Morhet <lmorhet@kalrayinc.com>
Tue, 4 Apr 2023 12:15:14 +0000 (14:15 +0200)
committerBenjamin Tissoires <benjamin.tissoires@redhat.com>
Thu, 13 Apr 2023 14:41:37 +0000 (16:41 +0200)
The documentation of the component (section 3.1.12 GET GPIO VALUES)
describes the hid report structure with two fields per gpio:
its value, followed by its direction.

However, the driver describes it with a wrong order:
direction followed by value.

Fix the structure representing the report answered by the chip to the
GET GPIO VALUES command.

Fixes commit 567b8e9fed8a ("HID: mcp2221: Fix GPIO output handling")

Signed-off-by: Louis Morhet <lmorhet@kalrayinc.com>
Link: https://lore.kernel.org/r/945967fbab56d53f9630ad3844b64734f8c3107e.1680602387.git.lmorhet@kalrayinc.com
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
drivers/hid/hid-mcp2221.c

index f74a977..fa20ed4 100644 (file)
@@ -79,8 +79,8 @@ struct mcp_get_gpio {
        u8 cmd;
        u8 dummy;
        struct {
-               u8 direction;
                u8 value;
+               u8 direction;
        } gpio[MCP_NGPIO];
 } __packed;