- Add recommended ignore properties to lint.xml.
- Make Fragment subclasses public.
- Truncate log tags at 23 chars.
- Fix one instance of passing a color ID instead of a color.
- Misc xml property fixes.
Change-Id: Ie8d6a8932cda72b7a239f6dfab56bd854f909820
<?xml version="1.0" encoding="UTF-8"?>
<lint>
- <!-- min-sdk doesn't apply to platform apps -->
+ <!--
+ Lint configuration for the framework-lint tool (go/fwlint). See
+ http://tools.android.com/tips/lint for full docs on the lint tool.
+ -->
+
+ <!-- min-sdk doesn't apply to platform apps. -->
<issue id="UsesMinSdkAttributes" severity="ignore" />
- <!-- Protected permissions don't apply to system apps -->
+ <!-- Protected permissions don't apply to system apps. -->
<issue id="ProtectedPermissions" severity="ignore" />
+
+ <!-- Other recommended suppressions copied from go/fwlint. -->
+ <issue id="Assert" severity="ignore" />
+ <issue id="ClickableViewAccessibility" severity="ignore" />
+ <issue id="GoogleAppIndexingWarning" severity="ignore" />
+ <issue id="MissingPermission" severity="ignore" />
+ <issue id="ParcelClassLoader" severity="ignore" />
+ <issue id="ParcelCreator" severity="ignore" />
+ <issue id="Registered" severity="ignore" />
+ <issue id="RtlHardcoded" severity="ignore" />
+ <issue id="ShiftFlags" severity="ignore" />
+ <issue id="SuspiciousImport" severity="ignore" />
+
+ <!-- Don't lint automatically translated strings. -->
+ <issue id="all">
+ <ignore path="res/values-*/strings.xml" />
+ </issue>
+
+ <!-- Don't warn about missing translations. -->
+ <issue id="MissingTranslation">
+ <ignore path="res/values/strings.xml" />
+ </issue>
+
</lint>
android:layout_height="match_parent"
android:id="@+id/coordinator_layout">
- <LinearLayout
+ <LinearLayout
android:layout_width="match_parent"
android:layout_height="match_parent"
android:orientation="vertical">
<include layout="@layout/directory_cluster"
android:layout_width="0dp"
- android:layout_weight="1"
android:elevation="8dp" />
</LinearLayout>
@Override
public void onCreate() {
+ super.onCreate();
+
final ActivityManager am = (ActivityManager) getSystemService(Context.ACTIVITY_SERVICE);
final int memoryClassBytes = am.getMemoryClass() * 1024 * 1024;
import android.graphics.Rect;
import android.util.AttributeSet;
import android.util.TypedValue;
-import android.view.View;
import android.widget.LinearLayout;
/**
@Override
protected void onFocusChanged(boolean gainFocus, int direction, Rect previouslyFocusedRect) {
- View indicator = findViewById(R.id.focus_indicator);
- if (gainFocus) {
- TypedValue color = new TypedValue();
- getContext().getTheme().resolveAttribute(android.R.attr.colorAccent, color, true);
- indicator.setBackgroundColor(color.data);
- } else {
- indicator.setBackgroundColor(android.R.color.transparent);
- }
+ TypedValue color = new TypedValue();
+ int colorId = gainFocus ? android.R.attr.colorAccent : android.R.color.transparent;
+ getContext().getTheme().resolveAttribute(colorId, color, true);
+
+ findViewById(R.id.focus_indicator).setBackgroundColor(color.data);
super.onFocusChanged(gainFocus, direction, previouslyFocusedRect);
}
}
import static android.os.Environment.isStandardDirectory;
import static com.android.documentsui.Shared.DEBUG;
-import java.io.File;
-import java.io.IOException;
-import java.util.List;
-
import android.app.Activity;
import android.app.AlertDialog;
import android.app.Dialog;
import android.app.DialogFragment;
import android.app.FragmentManager;
import android.app.FragmentTransaction;
-import android.content.ContentProvider;
import android.content.ContentProviderClient;
import android.content.ContentResolver;
import android.content.Context;
import android.text.TextUtils;
import android.util.Log;
+import java.io.File;
+import java.io.IOException;
+import java.util.List;
+
/**
* Activity responsible for handling {@link Intent#ACTION_OPEN_EXTERNAL_DOCUMENT}.
*/
public class OpenExternalDirectoryActivity extends Activity {
- private static final String TAG = "OpenExternalDirectoryActivity";
+ private static final String TAG = "OpenExternalDirectory";
private static final String FM_TAG = "open_external_directory";
private static final String EXTERNAL_STORAGE_AUTH = "com.android.externalstorage.documents";
private static final String EXTRA_FILE = "com.android.documentsui.FILE";
return intent;
}
- private static class OpenExternalDirectoryDialogFragment extends DialogFragment {
+ public static class OpenExternalDirectoryDialogFragment extends DialogFragment {
private File mFile;
private String mVolumeLabel;
import android.view.ViewGroup;
import com.android.documentsui.State;
-
import com.google.common.collect.Sets;
import java.util.ArrayList;
*/
final class ModelBackedDocumentsAdapter extends DocumentsAdapter {
- private static final String TAG = "ModelBackedDocumentsAdapter";
+ private static final String TAG = "ModelBackedDocuments";
public static final int ITEM_TYPE_DOCUMENT = 1;
public static final int ITEM_TYPE_DIRECTORY = 2;
import com.android.documentsui.BaseActivity;
import com.android.documentsui.DocumentsApplication;
-import com.android.documentsui.model.DocumentInfo;
import com.android.documentsui.R;
import com.android.documentsui.Snackbars;
+import com.android.documentsui.model.DocumentInfo;
/**
* Dialog to rename file or directory.
*/
-class RenameDocumentFragment extends DialogFragment {
+public class RenameDocumentFragment extends DialogFragment {
private static final String TAG_RENAME_DOCUMENT = "rename_document";
private DocumentInfo mDocument;