OSDN Git Service
(root)
/
uclinux-h8
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
1169735
)
power: supply: wm97xx_battery: remove redundant 2nd null check on pdata
author
Colin Ian King
<colin.king@canonical.com>
Thu, 29 Dec 2016 15:23:12 +0000
(15:23 +0000)
committer
Sebastian Reichel
<sre@kernel.org>
Wed, 4 Jan 2017 21:04:20 +0000
(22:04 +0100)
pdata is being null checked twice, the 2nd check is redundant code
and can be removed.
Fixes CoverityScan CID
1392340
"Logically dead code"
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
drivers/power/supply/wm97xx_battery.c
patch
|
blob
|
history
diff --git
a/drivers/power/supply/wm97xx_battery.c
b/drivers/power/supply/wm97xx_battery.c
index
e3edb31
..
bd4f666
100644
(file)
--- a/
drivers/power/supply/wm97xx_battery.c
+++ b/
drivers/power/supply/wm97xx_battery.c
@@
-175,11
+175,6
@@
static int wm97xx_bat_probe(struct platform_device *dev)
if (dev->id != -1)
return -EINVAL;
- if (!pdata) {
- dev_err(&dev->dev, "No platform_data supplied\n");
- return -EINVAL;
- }
-
if (gpio_is_valid(pdata->charge_gpio)) {
ret = gpio_request(pdata->charge_gpio, "BATT CHRG");
if (ret)