OSDN Git Service

net: korina: Remove not needed cache flushes
authorThomas Bogendoerfer <tsbogend@alpha.franken.de>
Sun, 18 Apr 2021 22:19:41 +0000 (00:19 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 19 Apr 2021 22:58:14 +0000 (15:58 -0700)
Descriptors are mapped uncached so there is no need to do any cache
handling for them.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/korina.c

index b56de01..c7abb4a 100644 (file)
@@ -231,7 +231,6 @@ static int korina_send_packet(struct sk_buff *skb, struct net_device *dev)
        dma_cache_wback((u32)skb->data, skb->len);
 
        /* Setup the transmit descriptor. */
-       dma_cache_inv((u32) td, sizeof(*td));
        td->ca = CPHYSADDR(skb->data);
        chain_prev = (lp->tx_chain_tail - 1) & KORINA_TDS_MASK;
        chain_next = (lp->tx_chain_tail + 1) & KORINA_TDS_MASK;
@@ -284,7 +283,6 @@ static int korina_send_packet(struct sk_buff *skb, struct net_device *dev)
                        lp->tx_chain_tail = chain_next;
                }
        }
-       dma_cache_wback((u32) td, sizeof(*td));
 
        netif_trans_update(dev);
        spin_unlock_irqrestore(&lp->lock, flags);
@@ -373,8 +371,6 @@ static int korina_rx(struct net_device *dev, int limit)
        u32 devcs, pkt_len, dmas;
        int count;
 
-       dma_cache_inv((u32)rd, sizeof(*rd));
-
        for (count = 0; count < limit; count++) {
                skb = lp->rx_skb[lp->rx_next_done];
                skb_new = NULL;
@@ -453,7 +449,6 @@ next:
                        ~DMA_DESC_COD;
 
                lp->rx_next_done = (lp->rx_next_done + 1) & KORINA_RDS_MASK;
-               dma_cache_wback((u32)rd, sizeof(*rd));
                rd = &lp->rd_ring[lp->rx_next_done];
                writel(~DMA_STAT_DONE, &lp->rx_dma_regs->dmas);
        }
@@ -468,7 +463,6 @@ next:
                rd->devcs = 0;
                skb = lp->rx_skb[lp->rx_next_done];
                rd->ca = CPHYSADDR(skb->data);
-               dma_cache_wback((u32)rd, sizeof(*rd));
                korina_chain_rx(lp, rd);
        }