OSDN Git Service

staging: rtl8192e: Rectify pointer comparisions with NULL
authorSuniel Mahesh <suniel.spartan@gmail.com>
Tue, 21 Mar 2017 09:01:02 +0000 (14:31 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 23 Mar 2017 13:30:03 +0000 (14:30 +0100)
This patch simplifies code by replacing explicit NULL comparison
with ! or unmark operator
Reported by checkpatch.pl for comparison to NULL could be
written '!foo' or 'foo'

Signed-off-by: Suniel Mahesh <suniel.spartan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtl8192e/rtl_core.c

index c23c229..f1bcefa 100644 (file)
@@ -477,7 +477,7 @@ static int _rtl92e_qos_assoc_resp(struct r8192_priv *priv,
        u32 size = sizeof(struct rtllib_qos_parameters);
        int set_qos_param = 0;
 
-       if ((priv == NULL) || (network == NULL))
+       if (!priv || !network)
                return 0;
 
        if (priv->rtllib->state != RTLLIB_LINKED)
@@ -790,7 +790,7 @@ static int _rtl92e_sta_down(struct net_device *dev, bool shutdownrf)
        if (priv->up == 0)
                return -1;
 
-       if (priv->rtllib->rtllib_ips_leave != NULL)
+       if (priv->rtllib->rtllib_ips_leave)
                priv->rtllib->rtllib_ips_leave(dev);
 
        if (priv->rtllib->state == RTLLIB_LINKED)