OSDN Git Service

RDMA/rtrs-clt: Use the bitmap API to allocate bitmaps
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 8 Jul 2022 16:47:27 +0000 (18:47 +0200)
committerLeon Romanovsky <leonro@nvidia.com>
Mon, 18 Jul 2022 09:03:21 +0000 (12:03 +0300)
Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.

It is less verbose and it improves the semantic.

Link: https://lore.kernel.org/r/ca9c5c8301d76d60de34640568b3db0d4401d050.1657298747.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Jack Wang <jinpu.wang@ionos.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/ulp/rtrs/rtrs-clt.c

index 9809c38..06c27a3 100644 (file)
@@ -1403,8 +1403,7 @@ static int alloc_permits(struct rtrs_clt_sess *clt)
        unsigned int chunk_bits;
        int err, i;
 
-       clt->permits_map = kcalloc(BITS_TO_LONGS(clt->queue_depth),
-                                  sizeof(long), GFP_KERNEL);
+       clt->permits_map = bitmap_zalloc(clt->queue_depth, GFP_KERNEL);
        if (!clt->permits_map) {
                err = -ENOMEM;
                goto out_err;
@@ -1426,7 +1425,7 @@ static int alloc_permits(struct rtrs_clt_sess *clt)
        return 0;
 
 err_map:
-       kfree(clt->permits_map);
+       bitmap_free(clt->permits_map);
        clt->permits_map = NULL;
 out_err:
        return err;
@@ -1440,7 +1439,7 @@ static void free_permits(struct rtrs_clt_sess *clt)
                wait_event(clt->permits_wait,
                           find_first_bit(clt->permits_map, sz) >= sz);
        }
-       kfree(clt->permits_map);
+       bitmap_free(clt->permits_map);
        clt->permits_map = NULL;
        kfree(clt->permits);
        clt->permits = NULL;