OSDN Git Service
(root)
/
sagit-ice-cold
/
kernel_xiaomi_msm8998.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
d8524ae
)
drm/msm: Odd PTR_ERR usage
author
Thomas Meyer
<thomas@m3y3r.de>
Mon, 16 Sep 2013 21:19:54 +0000
(23:19 +0200)
committer
Rob Clark
<robdclark@gmail.com>
Sat, 28 Sep 2013 12:53:26 +0000
(08:53 -0400)
The variable priv->kms is not initialized yet.
Found by "scripts/coccinelle/tests/odd_ptr_err.cocci".
PTR_ERR should access the value just tested by IS_ERR.
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
drivers/gpu/drm/msm/msm_drv.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/msm/msm_drv.c
b/drivers/gpu/drm/msm/msm_drv.c
index
008d772
..
fe03f9c
100644
(file)
--- a/
drivers/gpu/drm/msm/msm_drv.c
+++ b/
drivers/gpu/drm/msm/msm_drv.c
@@
-199,7
+199,7
@@
static int msm_load(struct drm_device *dev, unsigned long flags)
* imx drm driver on iMX5
*/
dev_err(dev->dev, "failed to load kms\n");
- ret = PTR_ERR(
priv->
kms);
+ ret = PTR_ERR(kms);
goto fail;
}