OSDN Git Service

x86/boot/KASLR: Always return a value from process_mem_region
authorLouis Taylor <louis@kragniz.eu>
Sat, 2 Mar 2019 18:49:29 +0000 (18:49 +0000)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 6 Mar 2019 21:55:30 +0000 (22:55 +0100)
When compiling with -Wreturn-type, clang warns:

arch/x86/boot/compressed/kaslr.c:704:1: warning: control may reach end of
      non-void function [-Wreturn-type]

This function's return statement should have been placed outside the
ifdeffed region. Move it there.

Fixes: 690eaa532057 ("x86/boot/KASLR: Limit KASLR to extract the kernel in immovable memory only")
Signed-off-by: Louis Taylor <louis@kragniz.eu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Cc: bp@alien8.de
Cc: hpa@zytor.com
Cc: fanc.fnst@cn.fujitsu.com
Cc: bhe@redhat.com
Cc: kirill.shutemov@linux.intel.com
Cc: jflat@chromium.org
Link: https://lkml.kernel.org/r/20190302184929.28971-1-louis@kragniz.eu
arch/x86/boot/compressed/kaslr.c

index fa0332d..2e53c05 100644 (file)
@@ -697,8 +697,8 @@ static bool process_mem_region(struct mem_vector *region,
                        return 1;
                }
        }
-       return 0;
 #endif
+       return 0;
 }
 
 #ifdef CONFIG_EFI