OSDN Git Service

drm/amd/display: Unconditionally print when DP sink power state fails
authorSrinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Mon, 17 Apr 2023 17:00:01 +0000 (22:30 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 18 Apr 2023 20:28:51 +0000 (16:28 -0400)
The previous 'commit ca9beb8aac68 ("drm/amd/display: Add logging when
setting DP sink power state fails")', it is better to unconditionally
print "failed to power up sink", because we are returning
DC_ERROR_UNEXPECTED.

Fixes: ca9beb8aac68 ("drm/amd/display: Add logging when setting DP sink power state fails")
Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
Cc: Fangzhi Zuo <Jerry.Zuo@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c

index ba98013..6d2d10d 100644 (file)
@@ -1043,9 +1043,7 @@ static enum dc_status wake_up_aux_channel(struct dc_link *link)
                                DP_SET_POWER,
                                &dpcd_power_state,
                                sizeof(dpcd_power_state));
-               if (status < 0)
-                       DC_LOG_DC("%s: Failed to power up sink: %s\n", __func__,
-                                 dpcd_power_state == DP_SET_POWER_D0 ? "D0" : "D3");
+               DC_LOG_DC("%s: Failed to power up sink\n", __func__);
                return DC_ERROR_UNEXPECTED;
        }