OSDN Git Service

drm/vgem: drop DRM_AUTH usage from the driver
authorEmil Velikov <emil.velikov@collabora.com>
Mon, 27 May 2019 08:17:39 +0000 (09:17 +0100)
committerEmil Velikov <emil.l.velikov@gmail.com>
Wed, 26 Jun 2019 14:00:40 +0000 (15:00 +0100)
The authentication can be circumvented, by design, by using the render
node.

From the driver POV there is no distinction between primary and render
nodes, thus we can drop the token.

Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190527081741.14235-11-emil.l.velikov@gmail.com
drivers/gpu/drm/vgem/vgem_drv.c

index d5ab6e4..386efc3 100644 (file)
@@ -246,8 +246,8 @@ unref:
 }
 
 static struct drm_ioctl_desc vgem_ioctls[] = {
-       DRM_IOCTL_DEF_DRV(VGEM_FENCE_ATTACH, vgem_fence_attach_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
-       DRM_IOCTL_DEF_DRV(VGEM_FENCE_SIGNAL, vgem_fence_signal_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
+       DRM_IOCTL_DEF_DRV(VGEM_FENCE_ATTACH, vgem_fence_attach_ioctl, DRM_RENDER_ALLOW),
+       DRM_IOCTL_DEF_DRV(VGEM_FENCE_SIGNAL, vgem_fence_signal_ioctl, DRM_RENDER_ALLOW),
 };
 
 static int vgem_mmap(struct file *filp, struct vm_area_struct *vma)