OSDN Git Service

fix some compiler warnings
authorIvailo Monev <xakepa10@gmail.com>
Mon, 18 Jul 2016 05:37:14 +0000 (05:37 +0000)
committerIvailo Monev <xakepa10@gmail.com>
Mon, 18 Jul 2016 05:37:14 +0000 (05:37 +0000)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
src/gui/dialogs/qwizard.cpp
src/gui/image/qnativeimage.cpp

index ff13aaa..ab50dac 100644 (file)
@@ -510,13 +510,15 @@ void QWizardPagePrivate::_q_updateCachedCompleteState()
 
 class QWizardAntiFlickerWidget : public QWidget
 {
-    QWizard *wizard;
     QWizardPrivate *wizardPrivate;
 public:
     QWizardAntiFlickerWidget(QWizard *wizard, QWizardPrivate *wizardPrivate)
         : QWidget(wizard)
-        , wizard(wizard)
-        , wizardPrivate(wizardPrivate) {}
+#if !defined(QT_NO_STYLE_WINDOWSVISTA)
+        , wizardPrivate(wizardPrivate)
+#endif
+    {}
+
 #if !defined(QT_NO_STYLE_WINDOWSVISTA)
 protected:
     void paintEvent(QPaintEvent *);
@@ -677,11 +679,8 @@ public:
     int maximumHeight;
 };
 
-static QString buttonDefaultText(int wstyle, int which, const QWizardPrivate *wizardPrivate)
+static QString buttonDefaultText(int wstyle, int which, const QWizardPrivate *wizard)
 {
-#if defined(QT_NO_STYLE_WINDOWSVISTA)
-    Q_UNUSED(wizardPrivate);
-#endif
     const bool macStyle = (wstyle == QWizard::MacStyle);
     switch (which) {
     case QWizard::BackButton:
@@ -690,7 +689,11 @@ static QString buttonDefaultText(int wstyle, int which, const QWizardPrivate *wi
         if (macStyle)
             return QWizard::tr("Continue");
         else
+#if defined(QT_NO_STYLE_WINDOWSVISTA)
+            return wizard->isVistaThemeEnabled()
+#else
             return wizardPrivate->isVistaThemeEnabled()
+#endif
                 ? QWizard::tr("&Next") : QWizard::tr("&Next >");
     case QWizard::CommitButton:
         return QWizard::tr("Commit");
index e7ae87c..c12d5c1 100644 (file)
@@ -158,7 +158,7 @@ QNativeImage::QNativeImage(int width, int height, QImage::Format format,bool /*
     int dd = info.depth();
     Visual *vis = (Visual*) info.visual();
 
-    if (!X11->use_mitshm || format != QImage::Format_RGB16 && X11->bppForDepth.value(dd) != 32) {
+    if (!X11->use_mitshm || (format != QImage::Format_RGB16 && X11->bppForDepth.value(dd) != 32)) {
         image = QImage(width, height, format);
         // follow good coding practice and set xshminfo attributes, though values not used in this case
         xshminfo.readOnly = true;