OSDN Git Service

drm/gma500: remove redundant ret variable
authorMinghao Chi <chi.minghao@zte.com.cn>
Wed, 12 Jan 2022 08:25:24 +0000 (08:25 +0000)
committerPatrik Jakobsson <patrik.r.jakobsson@gmail.com>
Wed, 12 Jan 2022 09:16:29 +0000 (10:16 +0100)
Return value directly instead of taking this in another redundant
variable.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220112082524.667552-1-chi.minghao@zte.com.cn
drivers/gpu/drm/gma500/cdv_intel_dp.c

index ba6ad14..74e6767 100644 (file)
@@ -82,7 +82,6 @@ i2c_algo_dp_aux_address(struct i2c_adapter *adapter, u16 address, bool reading)
 {
        struct i2c_algo_dp_aux_data *algo_data = adapter->algo_data;
        int mode = MODE_I2C_START;
-       int ret;
 
        if (reading)
                mode |= MODE_I2C_READ;
@@ -90,8 +89,7 @@ i2c_algo_dp_aux_address(struct i2c_adapter *adapter, u16 address, bool reading)
                mode |= MODE_I2C_WRITE;
        algo_data->address = address;
        algo_data->running = true;
-       ret = i2c_algo_dp_aux_transaction(adapter, mode, 0, NULL);
-       return ret;
+       return i2c_algo_dp_aux_transaction(adapter, mode, 0, NULL);
 }
 
 /*
@@ -122,13 +120,11 @@ static int
 i2c_algo_dp_aux_put_byte(struct i2c_adapter *adapter, u8 byte)
 {
        struct i2c_algo_dp_aux_data *algo_data = adapter->algo_data;
-       int ret;
 
        if (!algo_data->running)
                return -EIO;
 
-       ret = i2c_algo_dp_aux_transaction(adapter, MODE_I2C_WRITE, byte, NULL);
-       return ret;
+       return i2c_algo_dp_aux_transaction(adapter, MODE_I2C_WRITE, byte, NULL);
 }
 
 /*
@@ -139,13 +135,11 @@ static int
 i2c_algo_dp_aux_get_byte(struct i2c_adapter *adapter, u8 *byte_ret)
 {
        struct i2c_algo_dp_aux_data *algo_data = adapter->algo_data;
-       int ret;
 
        if (!algo_data->running)
                return -EIO;
 
-       ret = i2c_algo_dp_aux_transaction(adapter, MODE_I2C_READ, 0, byte_ret);
-       return ret;
+       return i2c_algo_dp_aux_transaction(adapter, MODE_I2C_READ, 0, byte_ret);
 }
 
 static int