OSDN Git Service

leds/led-class: Add missing put_device()
authorRicardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Fri, 31 Jul 2015 11:36:21 +0000 (13:36 +0200)
committerJacek Anaszewski <j.anaszewski@samsung.com>
Fri, 28 Aug 2015 12:06:19 +0000 (14:06 +0200)
Devices found by class_find_device must be freed with put_device().
Otherwise the reference count will not work properly.

Fixes: a96aa64cb572 ("leds/led-class: Handle LEDs with the same name")
Reported-by: Alan Tull <delicious.quinoa@gmail.com>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
drivers/leds/led-class.c

index beabfbc..ca51d58 100644 (file)
@@ -228,12 +228,15 @@ static int led_classdev_next_name(const char *init_name, char *name,
 {
        unsigned int i = 0;
        int ret = 0;
+       struct device *dev;
 
        strlcpy(name, init_name, len);
 
-       while (class_find_device(leds_class, NULL, name, match_name) &&
-              (ret < len))
+       while ((ret < len) &&
+              (dev = class_find_device(leds_class, NULL, name, match_name))) {
+               put_device(dev);
                ret = snprintf(name, len, "%s_%u", init_name, ++i);
+       }
 
        if (ret >= len)
                return -ENOMEM;