OSDN Git Service

[media] blackfin Kconfig: select is evil; use, instead depends on
authorMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 27 Dec 2012 23:21:14 +0000 (21:21 -0200)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 27 Dec 2012 23:21:14 +0000 (21:21 -0200)
Select is evil as it has issues with dependencies. Better to convert
it to use depends on.

That fixes a breakage with out-of-tree compilation of the media
tree.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/platform/blackfin/Kconfig

index 519990e..cc23997 100644 (file)
@@ -2,7 +2,6 @@ config VIDEO_BLACKFIN_CAPTURE
        tristate "Blackfin Video Capture Driver"
        depends on VIDEO_V4L2 && BLACKFIN && I2C
        select VIDEOBUF2_DMA_CONTIG
-       select VIDEO_BLACKFIN_PPI
        help
          V4L2 bridge driver for Blackfin video capture device.
          Choose PPI or EPPI as its interface.
@@ -12,3 +11,5 @@ config VIDEO_BLACKFIN_CAPTURE
 
 config VIDEO_BLACKFIN_PPI
        tristate
+       depends on VIDEO_BLACKFIN_CAPTURE
+       default VIDEO_BLACKFIN_CAPTURE