OSDN Git Service

media: dvb-frontends: cxd2880: return 0 instead of 'ret'.
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Thu, 26 Jan 2023 12:29:11 +0000 (13:29 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Wed, 8 Feb 2023 07:31:31 +0000 (08:31 +0100)
Since 'ret' is known to be 0, just return '0'. This fixes 10 smatch warnings:

cxd2880_tnrdmd_dvbt.c:836 cxd2880_tnrdmd_dvbt_check_demod_lock() warn: missing error code? 'ret'
cxd2880_tnrdmd_dvbt.c:841 cxd2880_tnrdmd_dvbt_check_demod_lock() warn: missing error code? 'ret'
cxd2880_tnrdmd_dvbt.c:896 cxd2880_tnrdmd_dvbt_check_ts_lock() warn: missing error code? 'ret'
cxd2880_tnrdmd_dvbt.c:901 cxd2880_tnrdmd_dvbt_check_ts_lock() warn: missing error code? 'ret'
cxd2880_tnrdmd_dvbt.c:904 cxd2880_tnrdmd_dvbt_check_ts_lock() warn: missing error code? 'ret'
cxd2880_tnrdmd_dvbt2.c:1027 cxd2880_tnrdmd_dvbt2_check_demod_lock() warn: missing error code? 'ret'
cxd2880_tnrdmd_dvbt2.c:1032 cxd2880_tnrdmd_dvbt2_check_demod_lock() warn: missing error code? 'ret'
cxd2880_tnrdmd_dvbt2.c:1087 cxd2880_tnrdmd_dvbt2_check_ts_lock() warn: missing error code? 'ret'
cxd2880_tnrdmd_dvbt2.c:1092 cxd2880_tnrdmd_dvbt2_check_ts_lock() warn: missing error code? 'ret'
cxd2880_tnrdmd_dvbt2.c:1095 cxd2880_tnrdmd_dvbt2_check_ts_lock() warn: missing error code? 'ret'

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Yasunari Takiguchi <Yasunari.Takiguchi@sony.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/dvb-frontends/cxd2880/cxd2880_tnrdmd_dvbt.c
drivers/media/dvb-frontends/cxd2880/cxd2880_tnrdmd_dvbt2.c

index fe3c6f8..c7e79da 100644 (file)
@@ -833,12 +833,12 @@ int cxd2880_tnrdmd_dvbt_check_demod_lock(struct cxd2880_tnrdmd
                else
                        *lock = CXD2880_TNRDMD_LOCK_RESULT_NOTDETECT;
 
-               return ret;
+               return 0;
        }
 
        if (sync_stat == 6) {
                *lock = CXD2880_TNRDMD_LOCK_RESULT_LOCKED;
-               return ret;
+               return 0;
        }
 
        ret =
@@ -854,7 +854,7 @@ int cxd2880_tnrdmd_dvbt_check_demod_lock(struct cxd2880_tnrdmd
        else
                *lock = CXD2880_TNRDMD_LOCK_RESULT_NOTDETECT;
 
-       return ret;
+       return 0;
 }
 
 int cxd2880_tnrdmd_dvbt_check_ts_lock(struct cxd2880_tnrdmd
@@ -893,15 +893,15 @@ int cxd2880_tnrdmd_dvbt_check_ts_lock(struct cxd2880_tnrdmd
                else
                        *lock = CXD2880_TNRDMD_LOCK_RESULT_NOTDETECT;
 
-               return ret;
+               return 0;
        }
 
        if (ts_lock) {
                *lock = CXD2880_TNRDMD_LOCK_RESULT_LOCKED;
-               return ret;
+               return 0;
        } else if (!unlock_detected) {
                *lock = CXD2880_TNRDMD_LOCK_RESULT_NOTDETECT;
-               return ret;
+               return 0;
        }
 
        ret =
@@ -915,5 +915,5 @@ int cxd2880_tnrdmd_dvbt_check_ts_lock(struct cxd2880_tnrdmd
        else
                *lock = CXD2880_TNRDMD_LOCK_RESULT_NOTDETECT;
 
-       return ret;
+       return 0;
 }
index dd32004..a9ab983 100644 (file)
@@ -1024,12 +1024,12 @@ int cxd2880_tnrdmd_dvbt2_check_demod_lock(struct cxd2880_tnrdmd
                else
                        *lock = CXD2880_TNRDMD_LOCK_RESULT_NOTDETECT;
 
-               return ret;
+               return 0;
        }
 
        if (sync_stat == 6) {
                *lock = CXD2880_TNRDMD_LOCK_RESULT_LOCKED;
-               return ret;
+               return 0;
        }
 
        ret =
@@ -1045,7 +1045,7 @@ int cxd2880_tnrdmd_dvbt2_check_demod_lock(struct cxd2880_tnrdmd
        else
                *lock = CXD2880_TNRDMD_LOCK_RESULT_NOTDETECT;
 
-       return ret;
+       return 0;
 }
 
 int cxd2880_tnrdmd_dvbt2_check_ts_lock(struct cxd2880_tnrdmd
@@ -1084,15 +1084,15 @@ int cxd2880_tnrdmd_dvbt2_check_ts_lock(struct cxd2880_tnrdmd
                else
                        *lock = CXD2880_TNRDMD_LOCK_RESULT_NOTDETECT;
 
-               return ret;
+               return 0;
        }
 
        if (ts_lock) {
                *lock = CXD2880_TNRDMD_LOCK_RESULT_LOCKED;
-               return ret;
+               return 0;
        } else if (!unlock_detected) {
                *lock = CXD2880_TNRDMD_LOCK_RESULT_NOTDETECT;
-               return ret;
+               return 0;
        }
 
        ret =
@@ -1106,7 +1106,7 @@ int cxd2880_tnrdmd_dvbt2_check_ts_lock(struct cxd2880_tnrdmd
        else
                *lock = CXD2880_TNRDMD_LOCK_RESULT_NOTDETECT;
 
-       return ret;
+       return 0;
 }
 
 int cxd2880_tnrdmd_dvbt2_set_plp_cfg(struct cxd2880_tnrdmd