OSDN Git Service

ath10k: remove redundant pointers 'dev' and 'noa'
authorColin Ian King <colin.king@canonical.com>
Mon, 9 Jul 2018 12:34:46 +0000 (13:34 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 30 Jul 2018 17:54:05 +0000 (20:54 +0300)
Pointers dev and noa are being assigned but are never used hence they
are redundant and can be removed.

Cleans up clang warnings:
warning: variable 'dev' set but not used [-Wunused-but-set-variable]
warning: variable 'noa' set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/ath10k/ahb.c
drivers/net/wireless/ath/ath10k/wmi-tlv.c

index fa39fff..c9bd0e2 100644 (file)
@@ -133,11 +133,8 @@ static void ath10k_ahb_clock_deinit(struct ath10k *ar)
 static int ath10k_ahb_clock_enable(struct ath10k *ar)
 {
        struct ath10k_ahb *ar_ahb = ath10k_ahb_priv(ar);
-       struct device *dev;
        int ret;
 
-       dev = &ar_ahb->pdev->dev;
-
        if (IS_ERR_OR_NULL(ar_ahb->cmd_clk) ||
            IS_ERR_OR_NULL(ar_ahb->ref_clk) ||
            IS_ERR_OR_NULL(ar_ahb->rtc_clk)) {
@@ -451,12 +448,10 @@ static int ath10k_ahb_resource_init(struct ath10k *ar)
 {
        struct ath10k_ahb *ar_ahb = ath10k_ahb_priv(ar);
        struct platform_device *pdev;
-       struct device *dev;
        struct resource *res;
        int ret;
 
        pdev = ar_ahb->pdev;
-       dev = &pdev->dev;
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        if (!res) {
index 95344c3..cdc1e64 100644 (file)
@@ -1820,7 +1820,6 @@ ath10k_wmi_tlv_op_gen_vdev_start(struct ath10k *ar,
 {
        struct wmi_tlv_vdev_start_cmd *cmd;
        struct wmi_channel *ch;
-       struct wmi_p2p_noa_descriptor *noa;
        struct wmi_tlv *tlv;
        struct sk_buff *skb;
        size_t len;
@@ -1878,7 +1877,6 @@ ath10k_wmi_tlv_op_gen_vdev_start(struct ath10k *ar,
        tlv = ptr;
        tlv->tag = __cpu_to_le16(WMI_TLV_TAG_ARRAY_STRUCT);
        tlv->len = 0;
-       noa = (void *)tlv->value;
 
        /* Note: This is a nested TLV containing:
         * [wmi_tlv][wmi_p2p_noa_descriptor][wmi_tlv]..