OSDN Git Service

enic: reset fetch index
authorParvi Kaustubhi <pkaustub@cisco.com>
Wed, 1 Nov 2017 15:44:46 +0000 (08:44 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 2 Nov 2017 05:17:11 +0000 (14:17 +0900)
Since we are allowing rx ring size modification, reset fetch index
everytime. Otherwise it could have a stale value that can lead to a null
pointer dereference.

Signed-off-by: Govindarajulu Varadarajan <gvaradar@cisco.com>
Signed-off-by: Parvi Kaustubhi <pkaustub@cisco.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/cisco/enic/vnic_rq.c

index 36bc2c7..f8aa326 100644 (file)
@@ -139,20 +139,8 @@ void vnic_rq_init(struct vnic_rq *rq, unsigned int cq_index,
        unsigned int error_interrupt_enable,
        unsigned int error_interrupt_offset)
 {
-       u32 fetch_index = 0;
-
-       /* Use current fetch_index as the ring starting point */
-       fetch_index = ioread32(&rq->ctrl->fetch_index);
-
-       if (fetch_index == 0xFFFFFFFF) { /* check for hardware gone  */
-               /* Hardware surprise removal: reset fetch_index */
-               fetch_index = 0;
-       }
-
-       vnic_rq_init_start(rq, cq_index,
-               fetch_index, fetch_index,
-               error_interrupt_enable,
-               error_interrupt_offset);
+       vnic_rq_init_start(rq, cq_index, 0, 0, error_interrupt_enable,
+                          error_interrupt_offset);
 }
 
 unsigned int vnic_rq_error_status(struct vnic_rq *rq)