OSDN Git Service

soc: qcom: apr: fix invalid msg_type check
authorSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Thu, 17 May 2018 16:03:53 +0000 (17:03 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 17 May 2018 17:11:23 +0000 (18:11 +0100)
Removed invalid msg_type check.
This also fixes below static checker warning:
apr.c:95:35: warning: comparison is always true due to limited range of
 data type [-Wtype-limits]
warn: always true condition '(msg_type != 69864) => (0-u16max != 69864)'

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/soc/qcom/apr.c

index 97f3622..57af8a5 100644 (file)
@@ -92,7 +92,7 @@ static int apr_callback(struct rpmsg_device *rpdev, void *buf,
        }
 
        msg_type = APR_HDR_FIELD_MT(hdr->hdr_field);
-       if (msg_type >= APR_MSG_TYPE_MAX && msg_type != APR_BASIC_RSP_RESULT) {
+       if (msg_type >= APR_MSG_TYPE_MAX) {
                dev_err(apr->dev, "APR: Wrong message type: %d\n", msg_type);
                return -EINVAL;
        }