OSDN Git Service

soc: qcom: irq-helper: Add comments to exposed APIs
authorRunmin Wang <runminw@codeaurora.org>
Tue, 6 Sep 2016 23:07:30 +0000 (16:07 -0700)
committerRunmin Wang <runminw@codeaurora.org>
Thu, 8 Sep 2016 23:49:41 +0000 (16:49 -0700)
Add comments and might_sleep() to warn that irq_blacklist_on/off
APIs should not be called in atomic context.

CRs-Fixed: 1063719
Change-Id: Ie6858243a666aeb21cc486208b9dd8221e9ad674
Signed-off-by: Runmin Wang <runminw@codeaurora.org>
drivers/soc/qcom/irq-helper.c

index 7bb371f..3708012 100644 (file)
@@ -78,10 +78,12 @@ IRQ_HELPER_ATTR(irq_blacklist_on, 0444, show_deploy, NULL);
 
 static struct irq_helper *irq_h;
 
+/* Do not call this API in an atomic context */
 int irq_blacklist_on(void)
 {
        bool flag = false;
 
+       might_sleep();
        if (!irq_h) {
                pr_err("%s: init function is not called", __func__);
                return -EPERM;
@@ -103,10 +105,12 @@ int irq_blacklist_on(void)
 }
 EXPORT_SYMBOL(irq_blacklist_on);
 
+/* Do not call this API in an atomic context */
 int irq_blacklist_off(void)
 {
        bool flag = false;
 
+       might_sleep();
        if (!irq_h) {
                pr_err("%s: init function is not called", __func__);
                return -EPERM;