OSDN Git Service

PCI/DPC: Remove indirection waiting for inactive link
authorKeith Busch <keith.busch@intel.com>
Mon, 16 Jul 2018 22:05:07 +0000 (17:05 -0500)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 19 Jul 2018 21:21:01 +0000 (16:21 -0500)
Simplify waiting for the contained link to become inactive, removing the
indirection to a unnecessary DPC-specific handler.

Signed-off-by: Keith Busch <keith.busch@intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Sinan Kaya <okaya@kernel.org>
Reviewed-by: Oza Pawandeep <poza@codeaurora.org>
drivers/pci/pcie/dpc.c

index fd6b96c..f03279f 100644 (file)
@@ -64,18 +64,12 @@ static int dpc_wait_rp_inactive(struct dpc_dev *dpc)
        return 0;
 }
 
-static void dpc_wait_link_inactive(struct dpc_dev *dpc)
-{
-       struct pci_dev *pdev = dpc->dev->port;
-
-       pcie_wait_for_link(pdev, false);
-}
-
 static pci_ers_result_t dpc_reset_link(struct pci_dev *pdev)
 {
        struct dpc_dev *dpc;
        struct pcie_device *pciedev;
        struct device *devdpc;
+
        u16 cap;
 
        /*
@@ -91,7 +85,7 @@ static pci_ers_result_t dpc_reset_link(struct pci_dev *pdev)
         * Wait until the Link is inactive, then clear DPC Trigger Status
         * to allow the Port to leave DPC.
         */
-       dpc_wait_link_inactive(dpc);
+       pcie_wait_for_link(pdev, false);
 
        if (dpc->rp_extensions && dpc_wait_rp_inactive(dpc))
                return PCI_ERS_RESULT_DISCONNECT;