OSDN Git Service

platform/chrome: cros_ec_proto: assign buffer size from protocol info
authorTzung-Bi Shih <tzungbi@kernel.org>
Thu, 9 Jun 2022 08:49:40 +0000 (08:49 +0000)
committerTzung-Bi Shih <tzungbi@kernel.org>
Fri, 10 Jun 2022 02:31:42 +0000 (02:31 +0000)
`din_size` is calculated from `ec_dev->max_response`.
`ec_dev->max_response` is further calculated from the protocol info.

To make it clear, assign `din_size` and `dout_size` from protocol info
directly.

Reviewed-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
Link: https://lore.kernel.org/r/20220609084957.3684698-5-tzungbi@kernel.org
drivers/platform/chrome/cros_ec_proto.c

index cfa3dac..4977c8d 100644 (file)
@@ -449,12 +449,8 @@ int cros_ec_query_all(struct cros_ec_device *ec_dev)
                        "using proto v%u\n",
                        ec_dev->proto_version);
 
-               ec_dev->din_size = ec_dev->max_response +
-                       sizeof(struct ec_host_response) +
-                       EC_MAX_RESPONSE_OVERHEAD;
-               ec_dev->dout_size = ec_dev->max_request +
-                       sizeof(struct ec_host_request) +
-                       EC_MAX_REQUEST_OVERHEAD;
+               ec_dev->din_size = proto_info->max_response_packet_size + EC_MAX_RESPONSE_OVERHEAD;
+               ec_dev->dout_size = proto_info->max_request_packet_size + EC_MAX_REQUEST_OVERHEAD;
 
                /*
                 * Check for PD