OSDN Git Service

net: enetc: fix check for allocation failure
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 13 Oct 2021 08:04:56 +0000 (11:04 +0300)
committerJakub Kicinski <kuba@kernel.org>
Wed, 13 Oct 2021 22:27:52 +0000 (15:27 -0700)
This was supposed to be a check for if dma_alloc_coherent() failed
but it has a copy and paste bug so it will not work.

Fixes: fb8629e2cbfc ("net: enetc: add support for software TSO")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Link: https://lore.kernel.org/r/20211013080456.GC6010@kili
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/enetc/enetc.c

index 3ae4f49..8e31fe1 100644 (file)
@@ -1767,8 +1767,10 @@ static int enetc_alloc_txbdr(struct enetc_bdr *txr)
                                              txr->bd_count * TSO_HEADER_SIZE,
                                              &txr->tso_headers_dma,
                                              GFP_KERNEL);
-       if (err)
+       if (!txr->tso_headers) {
+               err = -ENOMEM;
                goto err_alloc_tso;
+       }
 
        txr->next_to_clean = 0;
        txr->next_to_use = 0;