OSDN Git Service

drm: omapdrm: dss: replace ternary operator with max()
authorGuo Zhengkui <guozhengkui@vivo.com>
Tue, 17 May 2022 05:02:06 +0000 (13:02 +0800)
committerTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Fri, 9 Sep 2022 13:23:06 +0000 (16:23 +0300)
Fix the following coccicheck warning:

drivers/gpu/drm/omapdrm/dss/dispc.c:2454:21-22: WARNING opportunity for max()

Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220517050208.121488-1-guozhengkui@vivo.com
drivers/gpu/drm/omapdrm/dss/dispc.c

index c4de142..0ee344e 100644 (file)
@@ -2451,7 +2451,7 @@ static int dispc_ovl_calc_scaling_44xx(struct dispc_device *dispc,
 
        *decim_x = DIV_ROUND_UP(width, in_width_max);
 
-       *decim_x = *decim_x > decim_x_min ? *decim_x : decim_x_min;
+       *decim_x = max(*decim_x, decim_x_min);
        if (*decim_x > *x_predecim)
                return -EINVAL;