OSDN Git Service

media: dvb-usb/cxusb-analog.c: fix coccinelle warning, use ktime.h
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Thu, 30 May 2019 06:45:48 +0000 (02:45 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 3 Jun 2019 14:44:24 +0000 (10:44 -0400)
This patch fixes a coccinelle warning and includes ktime.h instead of
timekeeping.h. The first includes the latter, but the latter doesn't
exist before 3.17, causing problems for our compat build. It's easier
to just use ktime.h instead.

coccinelle warnings: (new ones prefixed by >>)

>> drivers/media/usb/dvb-usb/cxusb-analog.c:1498:41-42: WARNING: Use ARRAY_SIZE

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/usb/dvb-usb/cxusb-analog.c

index 9b42ca7..9b4f17e 100644 (file)
@@ -25,7 +25,7 @@
 #include <linux/device.h>
 #include <linux/slab.h>
 #include <linux/string.h>
-#include <linux/timekeeping.h>
+#include <linux/ktime.h>
 #include <linux/vmalloc.h>
 #include <media/drv-intf/cx25840.h>
 #include <media/tuner.h>
@@ -1622,8 +1622,7 @@ int cxusb_medion_analog_init(struct dvb_usb_device *dvbdev)
        /* TODO: setup audio samples insertion */
 
        ret = v4l2_subdev_call(cxdev->cx25840, core, s_io_pin_config,
-                              sizeof(cxusub_medion_pin_config) /
-                              sizeof(cxusub_medion_pin_config[0]),
+                              ARRAY_SIZE(cxusub_medion_pin_config),
                               cxusub_medion_pin_config);
        if (ret != 0)
                dev_warn(&dvbdev->udev->dev,