OSDN Git Service

staging: media: rkvdec: fix pm_runtime_get_sync() usage count
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 23 Apr 2021 15:19:11 +0000 (17:19 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 10 May 2021 09:36:33 +0000 (11:36 +0200)
The pm_runtime_get_sync() internally increments the
dev->power.usage_count without decrementing it, even on errors.
Replace it by the new pm_runtime_resume_and_get(), introduced by:
commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
in order to properly decrement the usage counter, avoiding
a potential PM usage counter leak.

Reviewed-by: Ezequiel Garcia <ezequiel@collabora.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/rkvdec/rkvdec.c

index d821661..8c17615 100644 (file)
@@ -658,7 +658,7 @@ static void rkvdec_device_run(void *priv)
        if (WARN_ON(!desc))
                return;
 
-       ret = pm_runtime_get_sync(rkvdec->dev);
+       ret = pm_runtime_resume_and_get(rkvdec->dev);
        if (ret < 0) {
                rkvdec_job_finish_no_pm(ctx, VB2_BUF_STATE_ERROR);
                return;