OSDN Git Service

ASoC: soc-pcm: Fix an uninitialized error code
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 11 Jan 2021 09:50:21 +0000 (12:50 +0300)
committerMark Brown <broonie@kernel.org>
Mon, 11 Jan 2021 14:03:55 +0000 (14:03 +0000)
The error path here doesn't set "ret" so it returns uninitialized data
instead of a negative error code.

Fixes: 2c1382840c19 ("ASoC: soc-pcm: disconnect BEs if the FE is not ready")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/X/wfXQFxeMLvpO+1@mwanda
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-pcm.c

index 29328ce..a253c9f 100644 (file)
@@ -2444,6 +2444,7 @@ static int dpcm_run_update_startup(struct snd_soc_pcm_runtime *fe, int stream)
                ret = -EINVAL;
                dev_err(fe->dev, "ASoC: FE %s is not ready %d\n",
                        fe->dai_link->name, fe->dpcm[stream].state);
+               ret = -EINVAL;
                goto disconnect;
        }