OSDN Git Service

drivers: net: xen-netfront: Simplify the calculation of variables
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Tue, 2 Feb 2021 10:17:49 +0000 (18:17 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 4 Feb 2021 18:55:24 +0000 (10:55 -0800)
Fix the following coccicheck warnings:

./drivers/net/xen-netfront.c:1816:52-54: WARNING !A || A && B is
equivalent to !A || B.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Link: https://lore.kernel.org/r/1612261069-13315-1-git-send-email-jiapeng.chong@linux.alibaba.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/xen-netfront.c

index 6ef2adb..cc19cd9 100644 (file)
@@ -1811,7 +1811,7 @@ static int setup_netfront(struct xenbus_device *dev,
         *  a) feature-split-event-channels == 0
         *  b) feature-split-event-channels == 1 but failed to setup
         */
-       if (!feature_split_evtchn || (feature_split_evtchn && err))
+       if (!feature_split_evtchn || err)
                err = setup_netfront_single(queue);
 
        if (err)