deal with TODO in CMake macro files [ci skip]

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

diff --git a/cmake/modules/KatieBuildMacros.cmake b/cmake/modules/KatieBuildMacros.cmake
index 70de60c..5a26d1e 100644 (file)
--- a/cmake/modules/KatieBuildMacros.cmake
+++ b/cmake/modules/KatieBuildMacros.cmake
@@ -182,8 +182,8 @@ function(KATIE_SETUP_TARGET FORTARGET)
                 get_directory_property(dirdefs COMPILE_DEFINITIONS)
                 get_directory_property(dirincs INCLUDE_DIRECTORIES)
                 set(mocargs)
+                # COMPILE_DEFINITIONS does not include undefine definitions
                 foreach(ddef ${dirdefs})
-                    # TODO: filter non -D, support -U too
                     set(mocargs ${mocargs} -D${ddef})
                 endforeach()
                 foreach(incdir ${dirincs})

diff --git a/cmake/modules/KatieMacros.cmake b/cmake/modules/KatieMacros.cmake
index 22572aa..8ade613 100644 (file)
--- a/cmake/modules/KatieMacros.cmake
+++ b/cmake/modules/KatieMacros.cmake
@@ -37,8 +37,8 @@ macro(KATIE_RESOURCES RESOURCES)
                     get_directory_property(dirdefs COMPILE_DEFINITIONS)
                     get_directory_property(dirincs INCLUDE_DIRECTORIES)
                     set(mocargs)
+                    # COMPILE_DEFINITIONS does not include undefine definitions
                     foreach(ddef ${dirdefs})
-                        # TODO: filter non -D, support -U too
                         set(mocargs ${mocargs} -D${ddef})
                     endforeach()
                     foreach(incdir ${dirincs})