OSDN Git Service

net: hns3: replace disable_irq by IRQ_NOAUTOEN flag
authorBarry Song <song.bao.hua@hisilicon.com>
Thu, 18 Jun 2020 01:02:10 +0000 (13:02 +1200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 19 Jun 2020 03:43:10 +0000 (20:43 -0700)
disable_irq() after request_irq() is still risk as there is a chance irq
can come after request_irq() and before disable_irq().
this should be done by IRQ_NOAUTOEN flag.

Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

index 3cd2216..1330820 100644 (file)
@@ -8,6 +8,7 @@
 #include <linux/cpu_rmap.h>
 #endif
 #include <linux/if_vlan.h>
+#include <linux/irq.h>
 #include <linux/ip.h>
 #include <linux/ipv6.h>
 #include <linux/module.h>
@@ -154,6 +155,7 @@ static int hns3_nic_init_irq(struct hns3_nic_priv *priv)
 
                tqp_vectors->name[HNAE3_INT_NAME_LEN - 1] = '\0';
 
+               irq_set_status_flags(tqp_vectors->vector_irq, IRQ_NOAUTOEN);
                ret = request_irq(tqp_vectors->vector_irq, hns3_irq_handle, 0,
                                  tqp_vectors->name, tqp_vectors);
                if (ret) {
@@ -163,8 +165,6 @@ static int hns3_nic_init_irq(struct hns3_nic_priv *priv)
                        return ret;
                }
 
-               disable_irq(tqp_vectors->vector_irq);
-
                irq_set_affinity_hint(tqp_vectors->vector_irq,
                                      &tqp_vectors->affinity_mask);