OSDN Git Service

phy: samsung-ufs: Fix IS_ERR argument
authorGustavo A. R. Silva <gustavoars@kernel.org>
Mon, 20 Jul 2020 13:27:18 +0000 (08:27 -0500)
committerVinod Koul <vkoul@kernel.org>
Tue, 21 Jul 2020 10:39:11 +0000 (16:09 +0530)
Fix IS_ERR argument in samsung_ufs_phy_symbol_clk_init(). The proper
argument to be passed to IS_ERR() is phy->rx1_symbol_clk.

This bug was detected with the help of Coccinelle.

Fixes: bca21e930451 ("phy: samsung-ufs: add UFS PHY driver for samsung SoC")
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Link: https://lore.kernel.org/r/20200720132718.GA13413@embeddedor
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/samsung/phy-samsung-ufs.c

index 43ef77d..9832599 100644 (file)
@@ -147,7 +147,7 @@ static int samsung_ufs_phy_symbol_clk_init(struct samsung_ufs_phy *phy)
        }
 
        phy->rx1_symbol_clk = devm_clk_get(phy->dev, "rx1_symbol_clk");
-       if (IS_ERR(phy->rx0_symbol_clk)) {
+       if (IS_ERR(phy->rx1_symbol_clk)) {
                dev_err(phy->dev, "failed to get rx1_symbol_clk clock\n");
                return PTR_ERR(phy->rx1_symbol_clk);
        }