OSDN Git Service

PCI/IOV: Enlarge virtfn sysfs name buffer
authorAlexey V. Vissarionov <gremlin@altlinux.org>
Sun, 18 Dec 2022 03:33:47 +0000 (06:33 +0300)
committerBjorn Helgaas <bhelgaas@google.com>
Wed, 18 Jan 2023 16:54:41 +0000 (10:54 -0600)
The sysfs link name "virtfn%u" constructed by pci_iov_sysfs_link() requires
17 bytes to contain the longest possible string.  Increase VIRTFN_ID_LEN to
accommodate that.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

[bhelgaas: commit log, comment at #define]
Fixes: dd7cc44d0bce ("PCI: add SR-IOV API for Physical Function driver")
Link: https://lore.kernel.org/r/20221218033347.23743-1-gremlin@altlinux.org
Signed-off-by: Alexey V. Vissarionov <gremlin@altlinux.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/iov.c

index 9522175..b2e8322 100644 (file)
@@ -14,7 +14,7 @@
 #include <linux/delay.h>
 #include "pci.h"
 
-#define VIRTFN_ID_LEN  16
+#define VIRTFN_ID_LEN  17      /* "virtfn%u\0" for 2^32 - 1 */
 
 int pci_iov_virtfn_bus(struct pci_dev *dev, int vf_id)
 {