OSDN Git Service

drm/bridge: analogix_dp: Don't power bridge in analogix_dp_bind
authorzain wang <wzz@rock-chips.com>
Mon, 5 Mar 2018 08:57:39 +0000 (09:57 +0100)
committerAndrzej Hajda <a.hajda@samsung.com>
Wed, 7 Mar 2018 15:17:56 +0000 (16:17 +0100)
The bridge does not need to be powered in analogix_dp_bind(), so
remove the calls to pm_runtime_get()/phy_power_on()/analogix_dp_init_dp()
as well as their power-off counterparts.

Cc: Stéphane Marchesin <marcheu@chromium.org>
Signed-off-by: zain wang <wzz@rock-chips.com>
Signed-off-by: Caesar Wang <wxt@rock-chips.com>
[the patch originally just removed the power_on portion, seanpaul removed
the power off code as well as improved the commit message]
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Thierry Escande <thierry.escande@collabora.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Tested-by: Heiko Stuebner <heiko@sntech.de>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180305085741.18896-2-m.szyprowski@samsung.com
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c

index 3f7a796..8475749 100644 (file)
@@ -1378,11 +1378,6 @@ analogix_dp_bind(struct device *dev, struct drm_device *drm_dev,
 
        pm_runtime_enable(dev);
 
-       pm_runtime_get_sync(dev);
-       phy_power_on(dp->phy);
-
-       analogix_dp_init_dp(dp);
-
        ret = devm_request_threaded_irq(&pdev->dev, dp->irq,
                                        analogix_dp_hardirq,
                                        analogix_dp_irq_thread,
@@ -1410,15 +1405,10 @@ analogix_dp_bind(struct device *dev, struct drm_device *drm_dev,
                goto err_disable_pm_runtime;
        }
 
-       phy_power_off(dp->phy);
-       pm_runtime_put(dev);
-
        return dp;
 
 err_disable_pm_runtime:
 
-       phy_power_off(dp->phy);
-       pm_runtime_put(dev);
        pm_runtime_disable(dev);
 
        return ERR_PTR(ret);