OSDN Git Service

Don't swallow eglCreateContext errors
authorJesse Hall <jessehall@google.com>
Mon, 12 Aug 2013 23:43:34 +0000 (16:43 -0700)
committerJesse Hall <jessehall@google.com>
Mon, 12 Aug 2013 23:43:34 +0000 (16:43 -0700)
If the implementation eglCreateContext failed, we called
eglGetError(), so we could check that it set the EGL error properly.
But since we'd already called this, when the app called eglGetError()
it would get EGL_SUCCESS!

Bug: 10181333
Change-Id: Ic45d3a8fcb8c4421e04844c6d2f52761790b5948

opengl/libs/EGL/eglApi.cpp

index 8a0522e..e5e2dc0 100644 (file)
@@ -552,12 +552,6 @@ EGLContext eglCreateContext(EGLDisplay dpy, EGLConfig config,
                 GLTrace_eglCreateContext(version, c);
 #endif
             return c;
-        } else {
-            EGLint error = eglGetError();
-            ALOGE_IF(error == EGL_SUCCESS,
-                    "eglCreateContext(%p, %p, %p, %p) returned EGL_NO_CONTEXT "
-                    "but no EGL error!",
-                    dpy, config, share_list, attrib_list);
         }
     }
     return EGL_NO_CONTEXT;