OSDN Git Service

ASoC: fsl_aud2htx: register platform component before registering cpu dai
authorShengjiu Wang <shengjiu.wang@nxp.com>
Thu, 25 Aug 2022 12:27:39 +0000 (20:27 +0800)
committerMark Brown <broonie@kernel.org>
Thu, 25 Aug 2022 13:17:30 +0000 (14:17 +0100)
There is no defer probe when adding platform component to
snd_soc_pcm_runtime(rtd), the code is in snd_soc_add_pcm_runtime()

snd_soc_register_card()
  -> snd_soc_bind_card()
    -> snd_soc_add_pcm_runtime()
      -> adding cpu dai
      -> adding codec dai
      -> adding platform component.

So if the platform component is not ready at that time, then the
sound card still registered successfully, but platform component
is empty, the sound card can't be used.

As there is defer probe checking for cpu dai component, then register
platform component before cpu dai to avoid such issue.

And the behavior of imx_pcm_dma_init() is same as common
devm_snd_dmaengine_pcm_register(), so use
devm_snd_dmaengine_pcm_register() instead

Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Link: https://lore.kernel.org/r/1661430460-5234-1-git-send-email-shengjiu.wang@nxp.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/fsl/fsl_aud2htx.c

index 873295f..bc1b9c6 100644 (file)
@@ -234,6 +234,16 @@ static int fsl_aud2htx_probe(struct platform_device *pdev)
 
        regcache_cache_only(aud2htx->regmap, true);
 
+       /*
+        * Register platform component before registering cpu dai for there
+        * is not defer probe for platform component in snd_soc_add_pcm_runtime().
+        */
+       ret = devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0);
+       if (ret) {
+               dev_err(&pdev->dev, "failed to pcm register\n");
+               return ret;
+       }
+
        ret = devm_snd_soc_register_component(&pdev->dev,
                                              &fsl_aud2htx_component,
                                              &fsl_aud2htx_dai, 1);
@@ -242,10 +252,6 @@ static int fsl_aud2htx_probe(struct platform_device *pdev)
                return ret;
        }
 
-       ret = imx_pcm_dma_init(pdev);
-       if (ret)
-               dev_err(&pdev->dev, "failed to init imx pcm dma: %d\n", ret);
-
        return ret;
 }