OSDN Git Service

Add logging for failure conditions.
authorAndy Huibers <andyhuibers@google.com>
Mon, 28 Apr 2014 20:18:31 +0000 (13:18 -0700)
committerAndy Huibers <andyhuibers@google.com>
Mon, 28 Apr 2014 23:16:17 +0000 (16:16 -0700)
Bug: 14364757
Change-Id: I252b1d79b94dabdc8960c7e243c50c8d50cb1306

src/com/android/camera/CameraActivity.java
src_pd/com/android/camera/util/UsageStatistics.java

index a5a2914..a9a6526 100644 (file)
@@ -479,16 +479,15 @@ public class CameraActivity extends Activity
     @Override
     public void onCameraDisabled(int cameraId) {
         UsageStatistics.instance().cameraFailure(
-                eventprotos.CameraFailure.FailureReason.SECURITY);
+                eventprotos.CameraFailure.FailureReason.SECURITY, null);
         CameraUtil.showErrorAndFinish(this,
                 R.string.camera_disabled);
     }
 
     @Override
     public void onDeviceOpenFailure(int cameraId, String info) {
-        // TODO: send "info" to UsageStatistics logging.
         UsageStatistics.instance().cameraFailure(
-                eventprotos.CameraFailure.FailureReason.OPEN_FAILURE);
+                eventprotos.CameraFailure.FailureReason.OPEN_FAILURE, info);
         CameraUtil.showErrorAndFinish(this, R.string.cannot_connect_camera);
     }
 
@@ -500,7 +499,7 @@ public class CameraActivity extends Activity
     @Override
     public void onReconnectionFailure(CameraManager mgr) {
         UsageStatistics.instance().cameraFailure(
-                eventprotos.CameraFailure.FailureReason.RECONNECT_FAILURE);
+                eventprotos.CameraFailure.FailureReason.RECONNECT_FAILURE, null);
         CameraUtil.showErrorAndFinish(this, R.string.cannot_connect_camera);
     }
 
@@ -1478,6 +1477,7 @@ public class CameraActivity extends Activity
     @Override
     public void onResume() {
         CameraPerformanceTracker.onEvent(CameraPerformanceTracker.ACTIVITY_RESUME);
+        Log.v(TAG, "Build info: " + Build.DISPLAY);
 
         mPaused = false;
 
index 2598b0e..1826440 100644 (file)
@@ -49,7 +49,7 @@ public class UsageStatistics {
                                       boolean front, boolean isHDR, float zoom) {
     }
 
-    public void cameraFailure(int cause) {
+    public void cameraFailure(int cause, String info) {
     }
 
     public void changeScreen(int newScreen, Integer interactionCause) {