OSDN Git Service

dma: sh: remove unnecessary platform_set_drvdata()
authorJingoo Han <jg1.han@samsung.com>
Mon, 26 Aug 2013 00:32:05 +0000 (09:32 +0900)
committerVinod Koul <vinod.koul@intel.com>
Tue, 27 Aug 2013 08:56:29 +0000 (14:26 +0530)
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/sh/shdmac.c
drivers/dma/sh/sudmac.c

index 77de5e4..6128715 100644 (file)
@@ -890,7 +890,6 @@ rst_err:
        pm_runtime_put(&pdev->dev);
        pm_runtime_disable(&pdev->dev);
 
-       platform_set_drvdata(pdev, NULL);
        shdma_cleanup(&shdev->shdma_dev);
 eshdma:
        synchronize_rcu();
@@ -919,8 +918,6 @@ static int sh_dmae_remove(struct platform_device *pdev)
        sh_dmae_chan_remove(shdev);
        shdma_cleanup(&shdev->shdma_dev);
 
-       platform_set_drvdata(pdev, NULL);
-
        synchronize_rcu();
 
        return 0;
index 4600b42..90ba2de 100644 (file)
@@ -391,7 +391,6 @@ static int sudmac_probe(struct platform_device *pdev)
 chan_probe_err:
        sudmac_chan_remove(su_dev);
 
-       platform_set_drvdata(pdev, NULL);
        shdma_cleanup(&su_dev->shdma_dev);
 
        return err;
@@ -405,7 +404,6 @@ static int sudmac_remove(struct platform_device *pdev)
        dma_async_device_unregister(dma_dev);
        sudmac_chan_remove(su_dev);
        shdma_cleanup(&su_dev->shdma_dev);
-       platform_set_drvdata(pdev, NULL);
 
        return 0;
 }